eclipse-wildwebdeveloper / eclipse-wildwebdeveloper/wildwebdeveloper
Clicking XML CodeLens link results in Unhandled event loop exception
まだ誰も着手していません。
- 主要言語
- Java
- スター
- 201
- フォーク
- 76
- 平均マージ
- 4日 7時間
- マージ済み PR(30日)
- 21
説明
In the eclipseide-wild-web-developer-0.11.5-win32.win32.x86_64.zip I get an Unhandled event loop exception when clicking on a <n> reference(s) XML CodeLens link.
Steps to reproduce using the following sample.dtd file:
<!ELEMENT sample (foo, bar)>
<!ELEMENT foo (bar*)>
<!ELEMENT bar (#PCDATA)>
- In Window > Preferences: XML (Wild Web Developer) > CodeLens tick the Enable XML CodeLens checkbox (see #636)
- Open
sample.dtdfile (see above) - Klick on the
1 reference(above line 2) or2 references(above line 3) XML CodeLens link
Result:
- Expected: Any kind of navigation to the clicked reference(s)
- Actual: No navigation; instead, the following Unhandled event loop exception will be logged:
eclipse.buildId=4.18.0.I20201202-1800
java.version=15.0.2
java.vendor=Oracle Corporation
BootLoader constants: OS=win32, ARCH=x86_64, WS=win32, NL=en_US
Framework arguments: -product org.eclipse.wildwebdeveloper.product.branding.product
Command-line arguments: -os win32 -ws win32 -arch x86_64 -product org.eclipse.wildwebdeveloper.product.branding.product
org.eclipse.ui
Error
Sun Feb 28 22:18:43 CET 2021
Unhandled event loop exception
java.lang.IllegalArgumentException: The handle object must not have a zero-length identifier
at org.eclipse.core.commands.common.HandleObjectManager.checkId(HandleObjectManager.java:65)
at org.eclipse.core.commands.CommandManager.getCommand(CommandManager.java:522)
at org.eclipse.ui.internal.commands.CommandService.getCommand(CommandService.java:159)
at org.eclipse.lsp4e.command.CommandExecutor.createEclipseCoreCommand(CommandExecutor.java:212)
at org.eclipse.lsp4e.command.CommandExecutor.executeCommandClientSide(CommandExecutor.java:185)
at org.eclipse.lsp4e.command.CommandExecutor.executeCommand(CommandExecutor.java:107)
at org.eclipse.lsp4e.operations.codelens.LSPCodeMining.performAction(LSPCodeMining.java:79)
at org.eclipse.jface.text.source.inlined.InlinedAnnotationSupport$MouseTracker.mouseUp(InlinedAnnotationSupport.java:318)
at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:224)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:89)
at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4209)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1037)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4026)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3626)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$5.run(PartRenderingEngine.java:1157)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:338)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1046)
at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:155)
at org.eclipse.ui.internal.Workbench.lambda$3(Workbench.java:644)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:338)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:551)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:156)
at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:152)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:203)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:401)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:255)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:64)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:564)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:653)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:590)
at org.eclipse.equinox.launcher.Main.run(Main.java:1461)
By the way, why it is called CodeLens which is a trademark owned by Microsoft and not Code Minings in Eclipse (see also Eclipse bug 526969 comment 15)?
コントリビューションガイド
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
調査の方向性
XML CodeLens を有効にして sample.dtd の手順で再現し、スタックトレースを基に LSPCodeMining.performAction と CommandExecutor.executeCommandClientSide/createEclipseCoreCommand を通じてクリックの処理を追跡する。参照リンクをクリックしても長さ 0 の識別子の例外が発生せず、期待どおりのナビゲーション動作になることを確認できれば完了。
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- java
- 領域
- desktop, devtools
- issue の種類
- バグ
- 難易度
- 4/5
- 見積もり時間
- 3〜5日
- 活発さ
- 停滞
- 明瞭さ
- おおむね明確
- 初心者へのやさしさ
- 45/100