eclipse-platform / eclipse-platform/eclipse.platform

Create a terminal settings default terminal executable setting - because On windows, cmd.exe is being chosen by default and it requires a custom env variable to change it

Aperta
#2,117 6 commenti 1 reazione 0 assegnatari Vedi su GitHub
bug
Lingua principale
Java
Stelle
165
Fork
174
Merge medio
2g 8h
PR unite (30g)
22

Descrizione

Use "Show in" and choose Terminal.

It keeps choosing cmd.exe by default. I cannot seem to get it to stop.

I removed it from everything yet it still uses it?

Image

It seems like this is set [here](https://github.com/eclipse-platform/eclipse.platform/blob/401d48340e4b43d76bb306acc01e306c3c93cb4e/terminal/bundles/org.eclipse.terminal.connector.local/src/org/eclipse/terminal/connector/local/launcher/LocalLauncherDelegate.java#L276). If a ComSpec environment variable is set, it uses that for the terminal. Otherwise, it seems to use cmd.exe on windows.

So an environment variable is needed to fix the issue. Which means the Terminal configuration dialog options are inadequate with this regard.

Suggested change

Image

Clicking button would show the choose terminal profile dialog, similar to dialog displayed when launching a terminal:

Image

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Start with terminal/bundles/org.eclipse.terminal.connector.local/src/org/eclipse/terminal/connector/local/launcher/LocalLauncherDelegate.java around line 276, then trace the Terminal configuration dialog and the terminal profile chooser used when launching a terminal. Done means Windows users can configure the default terminal executable through the settings UI without relying on the ComSpec environment variable.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
java
Ambito
cli, developer-experience
Tipo di issue
Funzionalità
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Attiva
Chiarezza
Abbastanza chiara
Idoneità per principianti
58/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.