eclipse-platform / eclipse-platform/eclipse.platform

Create a terminal settings default terminal executable setting - because On windows, cmd.exe is being chosen by default and it requires a custom env variable to change it

Offen
#2,117 6 Kommentare 1 Reaktion 0 zugewiesene Personen Auf GitHub ansehen
bug
Vorherrschende Sprache
Java
Sterne
165
Forks
174
Ø Merge
2 T. 8 Std.
Gemergte PRs (30 T.)
22

Beschreibung

Use "Show in" and choose Terminal.

It keeps choosing cmd.exe by default. I cannot seem to get it to stop.

I removed it from everything yet it still uses it?

Image

It seems like this is set [here](https://github.com/eclipse-platform/eclipse.platform/blob/401d48340e4b43d76bb306acc01e306c3c93cb4e/terminal/bundles/org.eclipse.terminal.connector.local/src/org/eclipse/terminal/connector/local/launcher/LocalLauncherDelegate.java#L276). If a ComSpec environment variable is set, it uses that for the terminal. Otherwise, it seems to use cmd.exe on windows.

So an environment variable is needed to fix the issue. Which means the Terminal configuration dialog options are inadequate with this regard.

Suggested change

Image

Clicking button would show the choose terminal profile dialog, similar to dialog displayed when launching a terminal:

Image

Beitragsleitfaden

Beitragsleitfaden öffnen

Rechercherichtung

Start with terminal/bundles/org.eclipse.terminal.connector.local/src/org/eclipse/terminal/connector/local/launcher/LocalLauncherDelegate.java around line 276, then trace the Terminal configuration dialog and the terminal profile chooser used when launching a terminal. Done means Windows users can configure the default terminal executable through the settings UI without relying on the ComSpec environment variable.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
java
Bereich
cli, developer-experience
Issue-Typ
Feature
Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Aktivitätsstatus
Aktiv
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
58/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.