eclipse-platform / eclipse-platform/eclipse.platform

Create a terminal settings default terminal executable setting - because On windows, cmd.exe is being chosen by default and it requires a custom env variable to change it

Open
#2,117 6 comments 1 reaction 0 assignees View on GitHub
bug
Dominant language
Java
Stars
165
Forks
174
Avg merge
2d 8h
Merged PRs (30d)
22

Description

Use "Show in" and choose Terminal.

It keeps choosing cmd.exe by default. I cannot seem to get it to stop.

I removed it from everything yet it still uses it?

Image

It seems like this is set [here](https://github.com/eclipse-platform/eclipse.platform/blob/401d48340e4b43d76bb306acc01e306c3c93cb4e/terminal/bundles/org.eclipse.terminal.connector.local/src/org/eclipse/terminal/connector/local/launcher/LocalLauncherDelegate.java#L276). If a ComSpec environment variable is set, it uses that for the terminal. Otherwise, it seems to use cmd.exe on windows.

So an environment variable is needed to fix the issue. Which means the Terminal configuration dialog options are inadequate with this regard.

Suggested change

Image

Clicking button would show the choose terminal profile dialog, similar to dialog displayed when launching a terminal:

Image

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.