dwyl / dwyl/github-backup

Pre-commit hook does not check test pass/failure before allowing commit ...

Aperta
#112 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
chore question
Lingua principale
Elixir
Stelle
33
Fork
3
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

I'm trying to debug why a test is not passing for #35
and when I attempt to make a commit on my branch (_where tests are failing_)
I am not _prevented_ from doing so ...

![image](https://user-images.githubusercontent.com/194400/37852927-618ff98e-2edc-11e8-9fcf-3bd937fd38de.png)

`pre_commit` is in the `mix.exs` file:
https://github.com/dwyl/github-backup/blob/9aec5c46b47922ea0cfd4c486008d0fb44b1248a/mix.exs#L50
But it's _unclear_ what command is being _run_ on the pre-commit hook ...

https://github.com/dwyl/github-backup/blob/5033458e0385a927faa7efb5cdb97584bf87d901/config/prod.exs#L34-L35

Why is the `pre-commit` defined in `prod.exs` ?

It would be _desirable_ to have the `pre-commit` run on `localhost` i.e. `dev.exs` ...
@SimonLab / @Cleop thoughts...?

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Direzione di ricerca

Start with the pre_commit definition in mix.exs and the referenced configuration in config/prod.exs, then compare it with dev.exs. Identify which command the hook runs and verify that a failing test prevents a local commit while the hook uses the appropriate environment.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
elixir, git
Ambito
testing-qa, tooling
Tipo di issue
Bug
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Ferma
Chiarezza
Da chiarire
Idoneità per principianti
35/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.