Pre-commit hook does not check test pass/failure before allowing commit ...
- Dominant language
- Elixir
- Stars
- 33
- Forks
- 3
- PR merge metrics
- No merged PRs in 30d
Description
I'm trying to debug why a test is not passing for #35
and when I attempt to make a commit on my branch (_where tests are failing_)
I am not _prevented_ from doing so ...
`pre_commit` is in the `mix.exs` file:
https://github.com/dwyl/github-backup/blob/9aec5c46b47922ea0cfd4c486008d0fb44b1248a/mix.exs#L50
But it's _unclear_ what command is being _run_ on the pre-commit hook ...
https://github.com/dwyl/github-backup/blob/5033458e0385a927faa7efb5cdb97584bf87d901/config/prod.exs#L34-L35
Why is the `pre-commit` defined in `prod.exs` ?
It would be _desirable_ to have the `pre-commit` run on `localhost` i.e. `dev.exs` ...
@SimonLab / @Cleop thoughts...?
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with the pre_commit definition in mix.exs and the referenced configuration in config/prod.exs, then compare it with dev.exs. Identify which command the hook runs and verify that a failing test prevents a local commit while the hook uses the appropriate environment.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- elixir, git
- Domain
- testing-qa, tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100