dwyl / dwyl/github-backup

Pre-commit hook does not check test pass/failure before allowing commit ...

Open
#112 1 comment 0 reactions 0 assignees View on GitHub
chore question
Dominant language
Elixir
Stars
33
Forks
3
PR merge metrics
No merged PRs in 30d

Description

I'm trying to debug why a test is not passing for #35
and when I attempt to make a commit on my branch (_where tests are failing_)
I am not _prevented_ from doing so ...

![image](https://user-images.githubusercontent.com/194400/37852927-618ff98e-2edc-11e8-9fcf-3bd937fd38de.png)

`pre_commit` is in the `mix.exs` file:
https://github.com/dwyl/github-backup/blob/9aec5c46b47922ea0cfd4c486008d0fb44b1248a/mix.exs#L50
But it's _unclear_ what command is being _run_ on the pre-commit hook ...

https://github.com/dwyl/github-backup/blob/5033458e0385a927faa7efb5cdb97584bf87d901/config/prod.exs#L34-L35

Why is the `pre-commit` defined in `prod.exs` ?

It would be _desirable_ to have the `pre-commit` run on `localhost` i.e. `dev.exs` ...
@SimonLab / @Cleop thoughts...?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.