dwyl / dwyl/elixir-pre-commit

"Not a git repository: '.git'" when using git dependent versioning

オープン
#29 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る
主要言語
Elixir
スター
46
フォーク
11
PR マージ指標
30日以内にマージされた PR はありません

説明

This is may not be directly related to the project, but I figure others could wind up in a similar pickle, and I haven't been able to find a solution to this yet, so I thought I'd reach out here.

For [this umbrella-project](https://github.com/BuddyGG/buddy_matching/tree/umbrella_conversion) using edeliver for deployment, I've had to implement auto revisioning inside each app's `mix.exs`. This is done as shown by the edeliver project [here](https://github.com/edeliver/edeliver/wiki/Umbrella-Projects#autoversioning).

My pre_commit hook is configured to run `test`, `format --check-formatted` and `credo`,
and this works fine when I call `mix pre_commit`, however when the pre_commit is triggered by actually using `git commit`,
the following happens:

```
...
fatal: Not a git repository: '.git'
fatal: Not a git repository: '.git'
fatal: Not a git repository: '.git'
fatal: Not a git repository: '.git'
...
```
This basically causes the code:
```elixir
def auto_version() do
{rev, _} = System.cmd("git", ["rev-parse", "--short", "HEAD"])
"1.0.0+#{String.trim_trailing(rev)}"
end
```

To cause an error, resulting in a bad formatting of the SemVer version, causing mix to throw the error:
`** (Mix) Expected :version to be a SemVer version, got: "1.0.0+"`.
and for the pre_commit to fail.

Now the bit which I cannot wrap my head around, is that when I add an `IO.inspect(File.cwd!())` to the auto_version/0 function, it returns the folder of the individual `mix.exs`-files, all of which should be under the git directory, and from which I can open IEx and call the function without error myself.

Similarly, if i manually run the hook `sh .git/hooks/pre-commit` from the directory from which I invoke the git commit, it also works.

Any ideas for a solution to this?

コントリビューションガイド

このリポジトリのコントリビューションガイドは索引されていません

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。