dry-python / dry-python/classes

Prevent an implementation for `int` class from operating on `bool` values

未關閉
#310 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
Python
星號
730
分支
30
PR 合併指標
30 天內沒有已合併 PR

描述

**Context.** Consider the following piece of code.

```python
from classes import typeclass

@typeclass
def render(data_value) -> str:
"""Pretty-print a value."""

@render.instance(int)
def _render_int(data_value: int) -> str:
return f'🔢 {data_value}'

render(True) == '🔢 True'
```
*(this should be runnable as-is on `classes 0.4.0`.)*

I would have expected this code to fail with a `NotImplementedError` because the `bool` case wasn't specified; but instead, that case is handled by the `int` implementation because

```pycon
In [3]: issubclass(bool, int)
Out[3]: True
```

**Decision.** In an `int` implementation, recognize if the provided value is actually a `bool` and refuse to process that value.

**Consequences.** I have been writing in Python for quite a few years now and I might even have encountered this relationship between `int` and `bool` types before, but that is not quite a type of thing that I keep in my short-term memory to be able to instantly recognize.

I believe this change can help avert bugs which might be hard to trace otherwise.

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。