dry-python / dry-python/classes
Prevent an implementation for `int` class from operating on `bool` values
- 主要语言
- Python
- 星标
- 730
- 派生
- 30
- PR 合并指标
- 30 天内没有已合并 PR
描述
**Context.** Consider the following piece of code.
```python
from classes import typeclass
@typeclass
def render(data_value) -> str:
"""Pretty-print a value."""
@render.instance(int)
def _render_int(data_value: int) -> str:
return f'🔢 {data_value}'
render(True) == '🔢 True'
```
*(this should be runnable as-is on `classes 0.4.0`.)*
I would have expected this code to fail with a `NotImplementedError` because the `bool` case wasn't specified; but instead, that case is handled by the `int` implementation because
```pycon
In [3]: issubclass(bool, int)
Out[3]: True
```
**Decision.** In an `int` implementation, recognize if the provided value is actually a `bool` and refuse to process that value.
**Consequences.** I have been writing in Python for quite a few years now and I might even have encountered this relationship between `int` and `bool` types before, but that is not quite a type of thing that I keep in my short-term memory to be able to instantly recognize.
I believe this change can help avert bugs which might be hard to trace otherwise.
贡献指南
评估
这个 Issue 还没有评估数据。