dropbox / dropbox/rules_node

Consider allowing a licence arg/option to gen_build_npm so output can live in third_party

Open
#18 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
53
Forks
11
PR merge metrics
No merged PRs in 30d

Description

I'm not that experienced with bazel but I feel like it would be fitting for the generated BUILD/shrikwrap files to exist in the `third_party` dir of a bazel project.

Unfortunately all BUILD files under `third_party` require a licence and there's no way to get `gen_build_npm` to include one in the created BUILD files.

Contributor guide

No contributing guide indexed for this repository

Research direction

Locate the gen_build_npm entry point and inspect how it creates BUILD and shrikwrap files. Check how existing options are parsed, then define completion as accepting a licence option and including that licence in generated files so they can be placed under a Bazel project's third_party directory.

Written by the indexing model from the issue text.

Assessment

Tech stack
node.js, python
Domain
build-system
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.