dotnet / dotnet/machinelearning-samples

Inconsistencies between F# and C# samples

Open
#267 0 comments 2 reactions 0 assignees View on GitHub
Dominant language
PowerShell
Stars
4.7k
Forks
2.7k
Avg merge
2d 22h
Merged PRs (30d)
1

Description

We reviewed and found some inconsistencies between the C# and F# samples.
This issue is just a convenient list for having the issues in a single place so we can all take it into account while updating the F# samples in the future.

If you fix any inconsistency below, please answer this thread, so we remove it, ok?

Please see the below table comparing the execution of F# and C# samples.

Sample Name | Comments | F# sample output |  c# sample output
-- | -- | -- | --
**Credit card Fraud Detection**  | 1)Accuracy is 1 in f# sample which is not correct. 2) The way o/p is displayed is not formatted properly in f# sample. No headers, no line breaks etc 3)The probability is showing in different units for c# and f#. for ex probability =0.9993f in f# and 4.303323E-05 in C# | Trainer and Predictor:![image](https://user-images.githubusercontent.com/22335043/53192184-b0581180-35c2-11e9-91c0-4e5a0545f978.png) | Trainer:![image](https://user-images.githubusercontent.com/22335043/53192239-cf56a380-35c2-11e9-988b-fe90e66ce27e.png)Predictor: ![image](https://user-images.githubusercontent.com/22335043/53192270-e39aa080-35c2-11e9-8d71-5087d095d99e.png)
**TensorFlow Estimator** | Comment: Can see an exception in f# o/p while finding path of filel | ![image](https://user-images.githubusercontent.com/22335043/53192303-fc0abb00-35c2-11e9-826e-360ee8c8a37d.png)  |  ![image](https://user-images.githubusercontent.com/22335043/53192324-10e74e80-35c3-11e9-8a28-518e05cf67b2.png)
**Github Labeler** | Comment: Getting build error while executing github labeler sample |![image](https://user-images.githubusercontent.com/22335043/53192351-1c3a7a00-35c3-11e9-937c-7b619fb94b3c.png)  | running fine for c# sample
**TesnorFlow Scorer** | Comment: Toaster 2 and Toaster 3 are shwoing accuracy as 1 | ![image](https://user-images.githubusercontent.com/22335043/53192375-28263c00-35c3-11e9-88c2-e01b5d1b5bd7.png)  |  ![image](https://user-images.githubusercontent.com/22335043/53192385-2fe5e080-35c3-11e9-912a-973161bd8239.png)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.