dotnet / dotnet/fsharp

Compiler silently drops diagnostics with unknown range

未关闭
#14,653 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
Area-Diagnostics Bug Impact-Medium
主要语言
F#
星标
4.3k
派生
876
平均合并
4 天 22 小时
30 天内合并 PR
144

描述

If a diagnostic would be emitted but it has an unknown range, we sometimes drop it on the floor. This seems non-ideal.

**Repro steps**

See the F# compiler built from https://github.com/Smaug123/fsharp-1/commit/76ea258b45dbea90e2ea28069d76065f1de6c354 . The test "Three types refined to obj are all warned" in ObjInference.fs incorrectly fails because it reports that no diagnostics were emitted. In fact diagnostics were requested, but were suppressed just before reporting: place a breakpoint at FSharpDiagnostic.fs line 203 in `ReportDiagnostic` to observe our decision not to emit the errors that arose on [line 185 of TypeRelations.fs](https://github.com/Smaug123/fsharp-1/commit/76ea258b45dbea90e2ea28069d76065f1de6c354#diff-99e9d8b56b1879061a50d28265e437772930bfe5c5ba465ede161a735e19adafR185) because their associated ranges were all the unknown range.

**Expected behavior**

The test "Three types refined to obj are all warned" should pass, because it notes that three diagnostics were emitted.

**Actual behavior**

No diagnostics were emitted, so the test fails.

**Known workarounds**

We could possibly just make sure that every diagnostic always has a meaningful range (which seems invasive and difficult), or we could run in "all errors" mode (but I don't understand the implications of that).

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。