dotnet / dotnet/fsharp

Compiler silently drops diagnostics with unknown range

Aberta
#14,653 1 comentário 0 reações 0 responsáveis Ver no GitHub
Area-Diagnostics Bug Impact-Medium
Linguagem predominante
F#
Estrelas
4.3k
Forks
876
Merge médio
4d 22h
PRs com merge (30d)
144

Descrição

If a diagnostic would be emitted but it has an unknown range, we sometimes drop it on the floor. This seems non-ideal.

**Repro steps**

See the F# compiler built from https://github.com/Smaug123/fsharp-1/commit/76ea258b45dbea90e2ea28069d76065f1de6c354 . The test "Three types refined to obj are all warned" in ObjInference.fs incorrectly fails because it reports that no diagnostics were emitted. In fact diagnostics were requested, but were suppressed just before reporting: place a breakpoint at FSharpDiagnostic.fs line 203 in `ReportDiagnostic` to observe our decision not to emit the errors that arose on [line 185 of TypeRelations.fs](https://github.com/Smaug123/fsharp-1/commit/76ea258b45dbea90e2ea28069d76065f1de6c354#diff-99e9d8b56b1879061a50d28265e437772930bfe5c5ba465ede161a735e19adafR185) because their associated ranges were all the unknown range.

**Expected behavior**

The test "Three types refined to obj are all warned" should pass, because it notes that three diagnostics were emitted.

**Actual behavior**

No diagnostics were emitted, so the test fails.

**Known workarounds**

We could possibly just make sure that every diagnostic always has a meaningful range (which seems invasive and difficult), or we could run in "all errors" mode (but I don't understand the implications of that).

Guia de contribuição

Abrir o guia de contribuição

Direção de pesquisa

Start with the "Three types refined to obj are all warned" test in ObjInference.fs and reproduce its missing diagnostics. Inspect ReportDiagnostic at FSharpDiagnostic.fs line 203 and the diagnostic-producing path at TypeRelations.fs line 185, then determine how unknown ranges should be handled. Done means the test passes and confirms that the three diagnostics are emitted.

Escrita pelo modelo de indexação a partir do texto da issue.

Avaliação

Stack de tecnologia
fsharp
Domínio
compilers
Tipo de issue
Bug
Dificuldade
4/5
Tempo estimado
3-5 dias
Status de atividade
Estagnada
Clareza
Razoavelmente clara
Facilidade para iniciantes
35/100

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.