dotnet / dotnet/dev-proxy

State/liveness keyed on PID alone is vulnerable to PID reuse

オープン
#1,755 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る
主要言語
C#
スター
832
フォーク
89
平均マージ
12時間 1分
マージ済み PR(30日)
23

説明

## Description

Dev Proxy tracks detached instances by PID alone (`state-.json`), and `StateManager` determines whether an instance is "alive" purely by checking whether a process with that PID currently exists (`StateManager.IsProcessRunning(int pid)` → `Process.GetProcessById`).

Operating systems recycle PIDs. After an instance exits (cleanly or via crash), its PID number can be reassigned to a completely unrelated process. When that happens:

- `IsProcessRunning(pid)` returns `true` for the stale state record, so Dev Proxy believes its old instance is still alive.
- Commands that key on liveness (`stop`, `status`, `LoadAllStatesAsync`, `FindSystemProxyInstanceAsync`, and the crash-recovery / orphaned-system-proxy reconciliation added in the `stop --force` fix) can act on — or refuse to act on — the wrong process.

This is a pre-existing, low-probability correctness issue in the whole detached-instance design; it is independent of any single command.

## Suggested fix

Store additional identity beyond the PID in the state file and verify it before treating a PID as "our" live instance. Options:

- Persist the process **start time** (`Process.StartTime`) alongside the PID, and in `IsProcessRunning` compare the running process's start time to the recorded value — a mismatch means the PID was reused and the record is stale.
- Optionally also persist the process name / a Dev Proxy marker as a secondary check.

`Process.StartTime` is available cross-platform in .NET and is the standard, low-cost way to disambiguate PID reuse.

## Notes

- Found while implementing the fix for #1731 (`devproxy stop --force` cannot restore the system proxy after a crashed instance). That fix relies on `asSystemProxy` state records to reconcile orphaned system-proxy registrations; PID-reuse hardening would make that reconciliation (and all liveness checks) more robust but is intentionally out of scope for that change.
- Affected code: `DevProxy/State/StateManager.cs` (`IsProcessRunning`, `LoadStateFromFileAsync`, `GetOrphanedSystemProxyStatesAsync`), `DevProxy/State/ProxyInstanceState.cs`.

コントリビューションガイド

コントリビューションガイドを開く

調査の方向性

まず DevProxy/State/StateManager.cs を読み、特に IsProcessRunning、LoadStateFromFileAsync、GetOrphanedSystemProxyStatesAsync を確認してから、DevProxy/State/ProxyInstanceState.cs を調べて状態ファイルのデータを理解します。切り離されたインスタンスのコマンドが PID の生存性をどのように使用しているかを追跡します。PID が再利用された場合に古い状態が拒否され、正当なインスタンスが引き続き認識されれば完了です。

索引モデルが issue の本文から書いたものです。

評価

技術スタック
csharp
領域
cli, devtools
issue の種類
バグ
難易度
4/5
見積もり時間
3〜5日
活発さ
静か
明瞭さ
おおむね明確
初心者へのやさしさ
55/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。