Adding New Filters Documentation

Open
#197 2 comments 0 reactions 1 assignee View on GitHub

@bd-j is already working on this.

Since Aug 9, 2024.

Assessment

This issue has not been assessed yet.

Description

Hello,

I wanted to confirm, as suggested in issue #46, that modifying the FILTER_LIST, magsun.dat, and filter_lambda_eff.dat files is important when adding new filters to python-fsps. My code gave non-physical results until I added information for my custom filters into these files.

Would it be possible to add documentation about adding new filters to the python-fsps documentation page, since the filter-adding process is different than that for FSPS? This might help others avoid this issue in the future, especially those who have less experience with github.

Thank you!

Dominant language
Python
Stars
76
Forks
45
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dfm/python-fsps

All issues in dfm/python-fsps

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.