developit / developit/microbundle

When providing `--css-modules insertHashHere` microbundle will treat all CSS files as CSS modules

未關閉
#876 0 則留言 4 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
JavaScript
星號
8.1k
分支
358
PR 合併指標
30 天內沒有已合併 PR

描述

Microbundle supports providing a custom hash generator name for `CSS modules` by providing `--css-modules insertHashPatternHere` (eg.: `--css-modules _[hash:base64:5]`.

### The Bug

But then Microbundle will also treat all CSS files as CSS modules, instead of just changing the generated signature of the actual CSS modules.

By the documentation, all CSS files should be considered a CSS module if a flag `--css-modules true` is provided.

### Possibly source of the Bug

The bug seems to originate on https://github.com/developit/microbundle/blob/b1a637486234a2ae784ccf0c512321e2d3efef7c/src/lib/css-modules.js#L8 where it only considers the "should only suffix modules" when the option `null` is being passed.

### The caveats

I suppose the `--css-modules` flag should only support `null`, `true` and `false` (Default Behaviour (Only when suffix), Enforce AutoCSS modules, Disable CSS modules completely).

Since there is the flag `--no-css-modules` there should be one for specifying the hash too. For example `--css-modules-hash _[hash:base64:5]`.

This would also avoid confusion since it is not documented in the README that using a custom hash would enforce CSS modules.

I would be more than happy to provide a patch 😄

貢獻指南

這個儲存庫沒有索引到貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。