developit / developit/microbundle

When providing `--css-modules insertHashHere` microbundle will treat all CSS files as CSS modules

未关闭
#876 0 条评论 4 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
JavaScript
星标
8.1k
派生
358
PR 合并指标
30 天内没有已合并 PR

描述

Microbundle supports providing a custom hash generator name for `CSS modules` by providing `--css-modules insertHashPatternHere` (eg.: `--css-modules _[hash:base64:5]`.

### The Bug

But then Microbundle will also treat all CSS files as CSS modules, instead of just changing the generated signature of the actual CSS modules.

By the documentation, all CSS files should be considered a CSS module if a flag `--css-modules true` is provided.

### Possibly source of the Bug

The bug seems to originate on https://github.com/developit/microbundle/blob/b1a637486234a2ae784ccf0c512321e2d3efef7c/src/lib/css-modules.js#L8 where it only considers the "should only suffix modules" when the option `null` is being passed.

### The caveats

I suppose the `--css-modules` flag should only support `null`, `true` and `false` (Default Behaviour (Only when suffix), Enforce AutoCSS modules, Disable CSS modules completely).

Since there is the flag `--no-css-modules` there should be one for specifying the hash too. For example `--css-modules-hash _[hash:base64:5]`.

This would also avoid confusion since it is not documented in the README that using a custom hash would enforce CSS modules.

I would be more than happy to provide a patch 😄

贡献指南

这个仓库没有索引到贡献指南

调研方向

Start in src/lib/css-modules.js around the referenced line and reproduce the behavior with --css-modules true, a custom hash pattern, and --no-css-modules. Done means a custom hash changes generated CSS-module signatures without making every CSS file a module, while the documented flag behaviors remain distinct.

由索引模型根据 Issue 内容生成。

评估

技术栈
javascript
领域
build-system, cli
Issue 类型
缺陷
难度
3/5
预计耗时
1-2 天
活跃度
停滞
描述清晰度
基本清楚
新手友好度
42/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。