developit / developit/microbundle

--format=modern still converts modern JS to old-style JS?

Ouverte
#775 5 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
JavaScript
Étoiles
8.1k
Forks
358
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

I was trying to figure out why my code was doing the wrong thing, and ran into the fact that using `--format=modern` still seems to yield legacy JS:

```
> microbundle watch -i ./src/react-app/ui.js -o ./public/preact-ui.js --format=modern --no-sourcemap --no-compress
```

turned the following:

```js
class MJUI extends Component {
constructor(props) {
// ...
}

renderGames(state) {
return state.games.map((g) => {
if (g.finished) return;

let joinOrStart = async () => {
// Note that these two operations are mutually
// exclusive, because owner's can't join, and
// non-owners can't start a game:
this.server.game.join(g.name);
this.server.game.start(g.name);
};

// ...
});
}

// ...
}
```

into:

```js
// ...

renderGames(state) {
var _this = this;

return state.games.map(g => {
if (g.finished) return;

let joinOrStart = async function joinOrStart() {
// Note that these two operations are mutually
// exclusive, because owner's can't join, and
// non-owners can't start a game:
_this.server.game.join(g.name);

_this.server.game.start(g.name);
};

// ...
```

Note that the filename has the `.modern.js` suffix, so something feels rather off?

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.