developit / developit/microbundle

--format=modern still converts modern JS to old-style JS?

Abierto
#775 5 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
JavaScript
Estrellas
8.1k
Forks
358
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

I was trying to figure out why my code was doing the wrong thing, and ran into the fact that using `--format=modern` still seems to yield legacy JS:

```
> microbundle watch -i ./src/react-app/ui.js -o ./public/preact-ui.js --format=modern --no-sourcemap --no-compress
```

turned the following:

```js
class MJUI extends Component {
constructor(props) {
// ...
}

renderGames(state) {
return state.games.map((g) => {
if (g.finished) return;

let joinOrStart = async () => {
// Note that these two operations are mutually
// exclusive, because owner's can't join, and
// non-owners can't start a game:
this.server.game.join(g.name);
this.server.game.start(g.name);
};

// ...
});
}

// ...
}
```

into:

```js
// ...

renderGames(state) {
var _this = this;

return state.games.map(g => {
if (g.finished) return;

let joinOrStart = async function joinOrStart() {
// Note that these two operations are mutually
// exclusive, because owner's can't join, and
// non-owners can't start a game:
_this.server.game.join(g.name);

_this.server.game.start(g.name);
};

// ...
```

Note that the filename has the `.modern.js` suffix, so something feels rather off?

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.