devcontainers / devcontainers/features

docker-outside-of-docker: Fix moby edge case ; gid 999

Aperta
#516 0 commenti 0 reazioni 1 assegnatario Rivendicata da @samruddhikhandale Vedi su GitHub
Lingua principale
Shell
Stelle
1.5k
Fork
621
Merge medio
6g 53m
PR unite (30g)
9

Descrizione

> As part of the tests, I figured out an issue when using moby. It seems that the group which moby creates hasn't the gid of 999 which is the default docker gid. I added a fix for such cases as well.

The commented out code (in this PR) was added in https://github.com/devcontainers/features/pull/443 which was merged an hour ago.
The issue with moby existed even before it, in order to avoid failures for folks, we can comment this bit for now.

I'll create a followup PR to fix that edge case.

_Originally posted by @samruddhikhandale in https://github.com/devcontainers/features/pull/515#pullrequestreview-1373542490_

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.