devcontainers / devcontainers/features

docker-outside-of-docker: Fix moby edge case ; gid 999

Abierto
#516 0 comentarios 0 reacciones 1 asignado Reclamado por @samruddhikhandale Ver en GitHub
Lenguaje dominante
Shell
Estrellas
1.5k
Forks
621
Merge medio
6 d 53 min
PR fusionados (30 d)
9

Descripción

> As part of the tests, I figured out an issue when using moby. It seems that the group which moby creates hasn't the gid of 999 which is the default docker gid. I added a fix for such cases as well.

The commented out code (in this PR) was added in https://github.com/devcontainers/features/pull/443 which was merged an hour ago.
The issue with moby existed even before it, in order to avoid failures for folks, we can comment this bit for now.

I'll create a followup PR to fix that edge case.

_Originally posted by @samruddhikhandale in https://github.com/devcontainers/features/pull/515#pullrequestreview-1373542490_

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.