devcontainers / devcontainers/cli

Specifying port for feature registry is broken

未关闭
#522 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
bug
主要语言
TypeScript
星标
3k
派生
457
平均合并
13 小时 17 分钟
30 天内合并 PR
6

描述

Features that come from registries with explicit port numbers are sometimes ignored, with only the last one remaining. For example, if devcontainer.json contains
```json
"features": {
"localhost:5000/name/repo/feature1:1": {},
"localhost:5000/name/repo/feature2:1": {}
}
```
only `feature2` will be installed. This happens because at some places in the CLI code the features are indexed by "whatever is before the first `:` character" (running `grep -rn "split(':')\[0\]"` on the repo shows multiple locations where this happens)

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。