devcontainers / devcontainers/cli

Specifying port for feature registry is broken

Ouverte
#522 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub
bug
Langage dominant
TypeScript
Étoiles
3k
Forks
457
Merge moyen
13 h 17 min
PR mergées (30 j)
6

Description

Features that come from registries with explicit port numbers are sometimes ignored, with only the last one remaining. For example, if devcontainer.json contains
```json
"features": {
"localhost:5000/name/repo/feature1:1": {},
"localhost:5000/name/repo/feature2:1": {}
}
```
only `feature2` will be installed. This happens because at some places in the CLI code the features are indexed by "whatever is before the first `:` character" (running `grep -rn "split(':')\[0\]"` on the repo shows multiple locations where this happens)

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.