devcontainers / devcontainers/cli

Specifying port for feature registry is broken

Open
#522 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
TypeScript
Stars
3k
Forks
457
Avg merge
13h 17m
Merged PRs (30d)
6

Description

Features that come from registries with explicit port numbers are sometimes ignored, with only the last one remaining. For example, if devcontainer.json contains
```json
"features": {
"localhost:5000/name/repo/feature1:1": {},
"localhost:5000/name/repo/feature2:1": {}
}
```
only `feature2` will be installed. This happens because at some places in the CLI code the features are indexed by "whatever is before the first `:` character" (running `grep -rn "split(':')\[0\]"` on the repo shows multiple locations where this happens)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.