devcontainers / devcontainers/cli

Improve experience of publishing Features|Templates to Dockerhub

Đang mở
#476 0 bình luận 0 reaction 0 người được giao Xem trên GitHub
feature-request
Ngôn ngữ chính
TypeScript
Star
3k
Fork
457
Merge trung bình
13 giờ 17 phút
Pull request đã merge (30 ngày)
6

Mô tả

Reported in the [Dev Container Community Slack](https://github.com/orgs/devcontainers/discussions/3) [**(ref)**](https://github.slack.com/archives/C0431R35H37/p1680402927120119).

Dockerhub has a lot of special cases that this CLI's container registry implementation needs to support. One that I noticed is that the key name in the `~/.docker/config.json` is `"https://index.docker.io/v1/"`. This CLI currently uses this key to map to the published registry name - all other examples omit `https` and don't have any additional path (`v1`). Both of these components will need to be handled when building the URI

This could be lumped into https://github.com/devcontainers/cli/issues/468, as I think this is mostly an auth special case.

Once fixed, add regression testing to https://github.com/devcontainers/cli/blob/main/src/test/container-features/registryCompatibilityOCI.test.ts.

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.