devcontainers / devcontainers/cli

Compose project name is stripped of punctuation when using podman-compose

未关闭
#1,017 0 条评论 1 个 reaction 已指派 1 人 已被 @v-Kaniska244 认领 在 GitHub 查看
主要语言
TypeScript
星标
3k
派生
457
平均合并
13 小时 17 分钟
30 天内合并 PR
6

描述

Currently, as of podman-compose 1.4.0, podman-compose allows punctuation in project name, and uses underscore for separating project name from image names. As a result, the following version checks are broken when using podman-compose:
- https://github.com/devcontainers/cli/blob/c246645f97fba402c3b1b95983e573e92bcec464/src/spec-node/dockerCompose.ts#L698
- https://github.com/devcontainers/cli/blob/c246645f97fba402c3b1b95983e573e92bcec464/src/spec-node/dockerCompose.ts#L465

This results in unreadable project names.

## Workaround

Point devcontainers (either cli or through vscode) to the below wrapper script. This will fake the version to be just right - after punctuation support but before change to use hyphens for separators.

```python
#!/usr/bin/env python

from sys import argv
from os import execvp

if argv[1:] == ['compose', 'version', '--short']:
print('2.7.0')
else:
execvp('podman', ['podman'] + argv[1:])
```

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。