devcontainers / devcontainers/cli

Compose project name is stripped of punctuation when using podman-compose

Aperta
#1,017 0 commenti 1 reazione 1 assegnatario Rivendicata da @v-Kaniska244 Vedi su GitHub
Lingua principale
TypeScript
Stelle
3k
Fork
457
Merge medio
13h 17m
PR unite (30g)
6

Descrizione

Currently, as of podman-compose 1.4.0, podman-compose allows punctuation in project name, and uses underscore for separating project name from image names. As a result, the following version checks are broken when using podman-compose:
- https://github.com/devcontainers/cli/blob/c246645f97fba402c3b1b95983e573e92bcec464/src/spec-node/dockerCompose.ts#L698
- https://github.com/devcontainers/cli/blob/c246645f97fba402c3b1b95983e573e92bcec464/src/spec-node/dockerCompose.ts#L465

This results in unreadable project names.

## Workaround

Point devcontainers (either cli or through vscode) to the below wrapper script. This will fake the version to be just right - after punctuation support but before change to use hyphens for separators.

```python
#!/usr/bin/env python

from sys import argv
from os import execvp

if argv[1:] == ['compose', 'version', '--short']:
print('2.7.0')
else:
execvp('podman', ['podman'] + argv[1:])
```

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.