dbcli / dbcli/mssql-cli

JSON RPC exception suppressing

Open
#359 0 comments 0 reactions 0 assignees View on GitHub
area: connection impact: code quality
Dominant language
Python
Stars
1.4k
Forks
191
PR merge metrics
No merged PRs in 30d

Description

There are quite a few areas in the JSON RPC module where exceptions are being suppressed. I believe we should be raising exceptions here, or at the very least providing more information to the user that their request encountered a failure.

I'm currently testing exception raising in [this branch](https://github.com/dbcli/mssql-cli/tree/ellbosch/jsonrpc-exception-tests), and have also created a test build which runs every day to see if new exceptions are raised. As of the time of this writing, no exceptions have been raised.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.