danielgtaylor / danielgtaylor/python-betterproto
Deepcopy incorrectly sets the 'active' oneof field to last field in structure (breaking which_one_of)
- Lenguaje dominante
- Python
- Estrellas
- 1.8k
- Forks
- 234
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Descripción
### Summary
When calling deepcopy on a proto, the oneOf field state gets overwritten.
### Reproduction Steps
1. Create a simple proto with two one_of fields.
2. set the first field
3. Call which_one_of which will return the first field
4. Call deepcopy on the proto
5. check which_one_of again.
6. The second field is returned.
The implementation of __deepcopy__ does this:
```
for name in self._betterproto.sorted_field_names:
value = self.__raw_get(name)
if value is not PLACEHOLDER:
kwargs[name] = deepcopy(value)
```
And of course, setattr sets the current group by field, which overwrites this.
one option is to simply make deepcopy one_of aware, using oneof_field_by_group, default initializing the nonset fields and adding them to a set, and then only iterating over the names that aren't in the set using the overall loop above.
### Expected Results
We preserve the correct one_of field
### Actual Results
The second one_of field is set.
### System Information
libprotoc 3.21.12
Python 3.11.9
Name: betterproto
Version: 2.0.0b6
Summary: A better Protobuf / gRPC generator & library
Home-page: https://github.com/danielgtaylor/python-betterproto
Author: Daniel G. Taylor
Author-email: danielgtaylor@gmail.com
License: MIT
Location: /usr/local/lib/python3.11/site-packages
Requires: grpclib, python-dateutil
Required-by:
### Checklist
- [X] I have searched the issues for duplicates.
- [X] I have shown the entire traceback, if possible.
- [X] I have verified this issue occurs on the latest prelease of betterproto which can be installed using `pip install -U --pre betterproto`, if possible.
Guía de contribución
Línea de trabajo
Comienza por la implementación de __deepcopy__ mostrada en el issue e inspecciona cómo oneof_field_by_group representa el campo activo. Reproduce el caso con un proto que contenga dos campos one_of y verifica después que deepcopy conserva el campo seleccionado antes de la copia y que which_one_of devuelve el mismo campo posteriormente.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- python
- Área
- backend-api-design
- Tipo de issue
- Error
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Estado de actividad
- Estancado
- Claridad
- Bien especificado
- Aptitud para principiantes
- 45/100