const-ae / const-ae/sparseMatrixStats

HEADS UP: New default for `ties.method` of {col,row}Ranks()

Aperta
#20 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
R
Stelle
55
Fork
3
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

# Background

**matrixStats** uses `ties.method = "max"` as the default for `colRanks()` and `rowRanks()` for legacy reasons, but we want eventually update to `ties.method = "average"` to align it with `base::rank()`, cf. https://github.com/HenrikBengtsson/matrixStats/issues/142.

The process for this migration with be:

1. Give a deprecation warning if `ties.method` is not explicitly specified (long time; several releases)
2. Give a defunct error if `ties.method` is not explicitly specified (long time; several releases)
3. Switch the new default to `ties.method = "average"`

This will have to take a long time in order to make sure end-users out there will notice this and update their code. I hope this will minimize the risk for existing code all of a sudden start producing different results.

# Issue

**sparseMatrixStats** gives an ERROR when I revdep check asserting `!isTRUE(missing(ties.method))`, cf. https://github.com/HenrikBengtsson/matrixStats/blob/feature/default-rank-ties.method/revdep/R_MATRIXSTATS_TIES_METHOD_MISSING%3Ddefunct/problems.md#sparsematrixstats

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.