const-ae / const-ae/sparseMatrixStats
HEADS UP: New default for `ties.method` of {col,row}Ranks()
- Vorherrschende Sprache
- R
- Sterne
- 55
- Forks
- 3
- PR-Merge-Kennzahlen
- Keine gemergten PRs in 30 T.
Beschreibung
# Background
**matrixStats** uses `ties.method = "max"` as the default for `colRanks()` and `rowRanks()` for legacy reasons, but we want eventually update to `ties.method = "average"` to align it with `base::rank()`, cf. https://github.com/HenrikBengtsson/matrixStats/issues/142.
The process for this migration with be:
1. Give a deprecation warning if `ties.method` is not explicitly specified (long time; several releases)
2. Give a defunct error if `ties.method` is not explicitly specified (long time; several releases)
3. Switch the new default to `ties.method = "average"`
This will have to take a long time in order to make sure end-users out there will notice this and update their code. I hope this will minimize the risk for existing code all of a sudden start producing different results.
# Issue
**sparseMatrixStats** gives an ERROR when I revdep check asserting `!isTRUE(missing(ties.method))`, cf. https://github.com/HenrikBengtsson/matrixStats/blob/feature/default-rank-ties.method/revdep/R_MATRIXSTATS_TIES_METHOD_MISSING%3Ddefunct/problems.md#sparsematrixstats
Beitragsleitfaden
Für dieses Repository ist kein Beitragsleitfaden indexiert
Rechercherichtung
Start by inspecting sparseMatrixStats implementations of colRanks() and rowRanks() and reproduce the revdep failure described in the linked R_MATRIXSTATS_TIES_METHOD_MISSING=defunct report. The work is done when the matrixStats ties.method migration no longer triggers the missing(ties.method) error in sparseMatrixStats.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- r
- Bereich
- data
- Issue-Typ
- Bug
- Schwierigkeit
- 3/5
- Geschätzter Aufwand
- 1-2 Tage
- Aktivitätsstatus
- Veraltet
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 35/100