conductor-oss / conductor-oss/python-sdk

Workers graceful shutdown being sure that current executions are not truncated

Abierto
#243 3 comentarios 2 reacciones 1 asignado Reclamado por @coderabhigupta Ver en GitHub
enhancement
Lenguaje dominante
Python
Estrellas
104
Forks
42
Merge medio
2 d 1 h
PR fusionados (30 d)
3

Descripción

Hi everyone,

I have Conductor workers running on Kubernetes pods.
I would like to handle the graceful shutdown in this way:

1. stop worker polling (I achieved this by implementing the function `paused()` of the `WorkerInterface`)
2. before executing the `sys.exit()` to terminate the pod, I want to be sure that the current worker executions will be finished without being truncated after the SIGTERM (so all the processes associated to the `TaskHandler` end)
3. finally execute `sys.exit()` to terminate the pod

I noticed that in the `TaskRunner` class, when the worker is paused, `None` is returned to the function `run_once`, but the function `run` is in a `while True` loop and I didn't understand how can I be sure when a worker is stopped and finished performing his task,

Is it possible to achieve the behaviour described in the 2nd point?
Thank you in advance.

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.