conductor-oss / conductor-oss/python-sdk

Workers graceful shutdown being sure that current executions are not truncated

Open
#243 3 comments 2 reactions 1 assignee Claimed by @coderabhigupta View on GitHub
enhancement
Dominant language
Python
Stars
104
Forks
42
Avg merge
2d 1h
Merged PRs (30d)
3

Description

Hi everyone,

I have Conductor workers running on Kubernetes pods.
I would like to handle the graceful shutdown in this way:

1. stop worker polling (I achieved this by implementing the function `paused()` of the `WorkerInterface`)
2. before executing the `sys.exit()` to terminate the pod, I want to be sure that the current worker executions will be finished without being truncated after the SIGTERM (so all the processes associated to the `TaskHandler` end)
3. finally execute `sys.exit()` to terminate the pod

I noticed that in the `TaskRunner` class, when the worker is paused, `None` is returned to the function `run_once`, but the function `run` is in a `while True` loop and I didn't understand how can I be sure when a worker is stopped and finished performing his task,

Is it possible to achieve the behaviour described in the 2nd point?
Thank you in advance.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.