conductor-oss / conductor-oss/javascript-sdk
Cannot update workflow without accessing deprecated methods
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 58
- Forks
- 20
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 7
Description
When trying to update a workflow using MetadataClient.registerWorkflowDef(workflow, true) with the latest build of conductor-oss, the request fails. It looks as though the Orkes implementation of POST /api/metadata/workflow supports an overwrite query param, but the Conductor OSS build doesn't.
The current way around this is to call client.metadataResource.update directly, but this results in a deprecation warning. While this is currently functional, it'd be great if there was a way to update directly using MetadataClient OR I suppose adding overwrite support to the Conductor OSS build would also do the trick.
Thanks!
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with MetadataClient.registerWorkflowDef(workflow, true) and compare its behavior with the direct client.metadataResource.update workaround. Check the POST /api/metadata/workflow request and determine whether MetadataClient can update without the deprecated method or whether overwrite support is needed; done means workflow updates succeed without a deprecation warning.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- api
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100