conductor-oss / conductor-oss/javascript-sdk

Cannot update workflow without accessing deprecated methods

Offen
#95 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Vorherrschende Sprache
TypeScript
Sterne
58
Forks
20
Ø Merge
1 T. 13 Std.
Gemergte PRs (30 T.)
7

Beschreibung

When trying to update a workflow using `MetadataClient.registerWorkflowDef(workflow, true)` with the latest build of conductor-oss, the request fails. It looks as though the [Orkes implementation](https://developer.orkescloud.com/swagger-ui/index.html?configUrl=/api-docs/swagger-config#/metadata-resource/create) of `POST /api/metadata/workflow` supports an `overwrite` query param, but the Conductor OSS build doesn't.

The current way around this is to call `client.metadataResource.update` directly, but this results in a deprecation warning. While this is currently functional, it'd be great if there was a way to update directly using `MetadataClient` OR I suppose adding `overwrite` support to the Conductor OSS build would also do the trick.

Thanks!

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Rechercherichtung

Start with MetadataClient.registerWorkflowDef(workflow, true) and compare its behavior with the direct client.metadataResource.update workaround. Check the POST /api/metadata/workflow request and determine whether MetadataClient can update without the deprecated method or whether overwrite support is needed; done means workflow updates succeed without a deprecation warning.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
typescript
Bereich
api
Issue-Typ
Bug
Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Aktivitätsstatus
Veraltet
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
45/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.