conductor-oss / conductor-oss/java-sdk

Http task: no fluent connectionTimeout() builder method

Aperta
#134 1 commento 0 reazioni 2 assegnatari Rivendicata da @kowser-orkes Vedi su GitHub
bug
Lingua principale
Java
Stelle
12
Fork
10
Merge medio
2g 8h
PR unite (30g)
4

Descrizione

## Summary

The `Http` builder class has a fluent `readTimeout(int)` method but no corresponding
`connectionTimeout(int)` method. Users who need to set `connectionTimeOut` must break
the fluent builder chain by calling `getHttpRequest().setConnectionTimeOut(n)` directly.

## Server baseline

Conductor **3.32.0-rc.9**

## Evidence

**Static:**
- `Http.java:84` — `public Http readTimeout(int readTimeout)` exists
- `Http.Input` (line 229-239) — has `connectionTimeOut` field, getter, setter
- No `connectionTimeout()` fluent method on `Http` class

**Live (2026-07-16):** Server correctly reads `connectionTimeOut` from `http_request`
(workflow registered with `connectionTimeOut: 3000` was accepted by Conductor OSS 3.32.0-rc.9).

## Inconsistency

```java
// readTimeout — has fluent method ✓
Http http = new Http("task_ref")
.url("https://example.com")
.method(HttpMethod.GET)
.readTimeout(5000);

// connectionTimeOut — NO fluent method ✗ (must break builder chain)
http.getHttpRequest().setConnectionTimeOut(3000);
```

## Proposed fix

```java
// Http.java — add alongside readTimeout()
public Http connectionTimeout(int connectionTimeout) {
this.httpRequest.setConnectionTimeOut(connectionTimeout);
return this;
}
```

## Related

Discovered during systematic SDK audit against Conductor OSS 3.32.0-rc.9.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.