conductor-oss / conductor-oss/java-sdk

Http task: no fluent connectionTimeout() builder method

Offen
#134 1 Kommentar 0 Reaktionen 2 zugewiesene Personen Beansprucht von @kowser-orkes Auf GitHub ansehen
bug
Vorherrschende Sprache
Java
Sterne
12
Forks
10
Ø Merge
2 T. 8 Std.
Gemergte PRs (30 T.)
4

Beschreibung

## Summary

The `Http` builder class has a fluent `readTimeout(int)` method but no corresponding
`connectionTimeout(int)` method. Users who need to set `connectionTimeOut` must break
the fluent builder chain by calling `getHttpRequest().setConnectionTimeOut(n)` directly.

## Server baseline

Conductor **3.32.0-rc.9**

## Evidence

**Static:**
- `Http.java:84` — `public Http readTimeout(int readTimeout)` exists
- `Http.Input` (line 229-239) — has `connectionTimeOut` field, getter, setter
- No `connectionTimeout()` fluent method on `Http` class

**Live (2026-07-16):** Server correctly reads `connectionTimeOut` from `http_request`
(workflow registered with `connectionTimeOut: 3000` was accepted by Conductor OSS 3.32.0-rc.9).

## Inconsistency

```java
// readTimeout — has fluent method ✓
Http http = new Http("task_ref")
.url("https://example.com")
.method(HttpMethod.GET)
.readTimeout(5000);

// connectionTimeOut — NO fluent method ✗ (must break builder chain)
http.getHttpRequest().setConnectionTimeOut(3000);
```

## Proposed fix

```java
// Http.java — add alongside readTimeout()
public Http connectionTimeout(int connectionTimeout) {
this.httpRequest.setConnectionTimeOut(connectionTimeout);
return this;
}
```

## Related

Discovered during systematic SDK audit against Conductor OSS 3.32.0-rc.9.

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.