conda-forge / conda-forge/python-feedstock

Branding patches cause issues with certain wheels

未關閉
#330 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
Shell
星號
47
分支
112
平均合併
2 天 9 小時
30 天內合併 PR
18

描述

This recipe patches the CPython source code to include **conda-forge branding** in the interpreter banner, namely `| packaged by conda-forge |`. However, since this banner is validated in `platform.py` (to prevent mismatches between the Python runtime and the python home in use), the `platform.py` is also patched for this validation to pass. Both patches are done in [brand-python.py](https://github.com/conda-forge/python-feedstock/blob/master/recipe/brand_python.py).

Now, I have the following issue with this: we are working on a PyPI wheel for the xeus-python jupyter kernel, for which we have a functional conda package, and which embeds Python. The conda package simply links with libpython.so and all is fine, but for the wheel, since we generally can't rely on Python distributions providing a `libpython.so` shared object, our PyPI manylinux wheel is statically linked with `libpython.a`. This causes the banner to *not* be the one from conda-forge an to cause a mismatch with conda-forge's patched validation regex.

To solve this issue, we would need to either renounce to the branding in the banner, or make the new regex slightly more flexible to also accept the original banner from the unpatched python interpreter.

cc @mingwandroid @jjhelmus @johanmabille.

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。