conda-forge / conda-forge/python-feedstock

Branding patches cause issues with certain wheels

Aperta
#330 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Shell
Stelle
47
Fork
112
Merge medio
2g 9h
PR unite (30g)
18

Descrizione

This recipe patches the CPython source code to include **conda-forge branding** in the interpreter banner, namely `| packaged by conda-forge |`. However, since this banner is validated in `platform.py` (to prevent mismatches between the Python runtime and the python home in use), the `platform.py` is also patched for this validation to pass. Both patches are done in [brand-python.py](https://github.com/conda-forge/python-feedstock/blob/master/recipe/brand_python.py).

Now, I have the following issue with this: we are working on a PyPI wheel for the xeus-python jupyter kernel, for which we have a functional conda package, and which embeds Python. The conda package simply links with libpython.so and all is fine, but for the wheel, since we generally can't rely on Python distributions providing a `libpython.so` shared object, our PyPI manylinux wheel is statically linked with `libpython.a`. This causes the banner to *not* be the one from conda-forge an to cause a mismatch with conda-forge's patched validation regex.

To solve this issue, we would need to either renounce to the branding in the banner, or make the new regex slightly more flexible to also accept the original banner from the unpatched python interpreter.

cc @mingwandroid @jjhelmus @johanmabille.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.