common-workflow-language / common-workflow-language/schema_salad

[Codegen] Remove redundancies in interfaces generated by the Java and TypeScript codegens

Open
#489 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
86
Forks
64
Avg merge
19h 24m
Merged PRs (30d)
19

Description

Currently, the Interfaces generated by the Java and TypeScript codegens contain redundancies in their fields caused by fields being passed down the inheritance hierarchy of the classes by the codegen.

Two possible solutions:
a) Mark inherited fields with a flag like `is_inherited`
b) Make sure that subclasses get generated after parent classes (might already be the case?). This means you can store which fields are from which class and subclasses can check if a class it is inheriting from already has the field that is currently being declared

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.