common-workflow-language / common-workflow-language/schema_salad

[Codegen] Remove redundancies in interfaces generated by the Java and TypeScript codegens

Offen
#489 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Vorherrschende Sprache
Python
Sterne
86
Forks
64
Ø Merge
19 Std. 24 Min.
Gemergte PRs (30 T.)
19

Beschreibung

Currently, the Interfaces generated by the Java and TypeScript codegens contain redundancies in their fields caused by fields being passed down the inheritance hierarchy of the classes by the codegen.

Two possible solutions:
a) Mark inherited fields with a flag like `is_inherited`
b) Make sure that subclasses get generated after parent classes (might already be the case?). This means you can store which fields are from which class and subclasses can check if a class it is inheriting from already has the field that is currently being declared

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.