common-workflow-language / common-workflow-language/cwltool

anonymous directory are allowed to only have a listing

オープン
#226 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る
主要言語
Python
スター
376
フォーク
255
平均マージ
2日 7時間
マージ済み PR(30日)
12

説明

According to my reading of http://www.commonwl.org/v1.0/Workflow.html#Directory

```
if d["class"] == "Directory" and ("listing" not in d or "basename" not in d):
raise validate.ValidationException("Anonymous directory object must have 'listing' and 'basename' fields.")
```

is incorrect

https://github.com/common-workflow-language/cwltool/blob/master/cwltool/pathmapper.py#L59

@tetron Am I reading the spec wrong? Seems that if there is a listing and nothing else then "[t]he implementation must assign a unique identifier for the location field.", then the basename follows "If not provided, the implementation must set [the basename] based on the location field by taking the final path component after parsing location as an IRI."

This came up while debugging https://www.biostars.org/p/216220/ -- so perhaps the issue is that the reference implementation thinks this directory is anonymous when in fact it will have a real path in the output directory.

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。