coderedcorp / coderedcorp/coderedcms

Secure file upload - email link is incorrect

Aperta
#670 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Type: Bug
Lingua principale
Python
Stelle
765
Fork
154
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

I've created a job application form that has a secure file upload for CVs/Resumes.
When we receive the email with the application form information we also get a link to the uploaded file, which should only accessible when logged into the admin panel.

However, when I log in the link still goes to a "Page Not Found" page.

If I download the form data (the data doesn't fit on the form view page, might be another issue), the link is to the specific file, i.e. example.com/protected/[encrypted_name]/[file_name].pdf
The link in the email includes white space, and so doesn't highlight the full link, it just shows the bit up to the white space and then continues the text outside of the link.

#### Steps to reproduce
Steps to reproduce the behavior:
Create web form with upload file.
Upload file with file name like: "This is an example.docx"
email received will show: http://example.com/protected/[encrypted_name]/This (LINK) is an example.docx (NOT LINK)

#### Expected behavior
Filename should be encoded for web so that the link displays properly in the email.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Direzione di ricerca

No file or test is named in the issue. Start by reproducing a secure upload whose filename contains spaces and trace the email link generation; done means the complete protected-file URL is encoded and rendered as one clickable link, while the admin access behavior remains intact.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
django, python
Ambito
backend
Tipo di issue
Bug
Difficoltà
2/5
Tempo stimato
1-3 ore
Stato di attività
Ferma
Chiarezza
Specificata chiaramente
Idoneità per principianti
48/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.