coder / coder/envbuilder

Fallback image still uses username from failed build

Aperta
#452 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Go
Stelle
300
Fork
64
Merge medio
20m
PR unite (30g)
1

Descrizione

When a Docker image fails to build and the fallback image is used, Envbuilder still attempts to use the username specified in the broken Dockerfile and tries to connect to the fallback image using that username. Often the fallback image doesn’t have the user in the original image and so we cannot connect to the fallback image.

# Reproduction
Dockerfile:
```
FROM mcr.micrdosoft.com/devcontainers/base:ubuntu-22.04
USER vscode
RUN false
```

Fallback image: `ubuntu:24.04`

Should the user be set to `root` when the fallback image is used or even allow a ENVBUILDER_FALLBACK_IMAGE_USER environment variable to be specified?

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.