coder / coder/code-server

The value of hashed-password can be used to open CodeServer directly, which has security problem

未關閉
#7,696 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
bug security triage
主要語言
TypeScript
星號
79.3k
分支
6.8k
平均合併
2 天 6 小時
30 天內合併 PR
41

描述

### Is there an existing issue for this?

- [x] I have searched the existing issues

### OS/Web Information

- Web Browser: Chrome 143.0.7499.170
- Local OS: windows
- Remote OS: ubuntu 22.04, jupyterlab service
- Remote Architecture: x86
- `code-server --version`: v4.108.0

### Steps to Reproduce

1. prepare "hashed-password" using command `echo -n "xxx" | npx argon2-cli -e`
2. edit ~/.config/code-server/config.yaml,auth: password, hashed-password:"$argon2i$v=19$m=4096,t=3,p=1$xxx$xxx"
3. start code-server using command `code-server --port 7756`
4. using jupyter_server_proxy to visit code-server service, concatenate a URL as https://base_url/proxy/7756/
5. when the code-server login page occurs, skip input the xxx into the password area. F12 edit the application cookie, set key=code-server-session, value="$argon2i$v=19$m=4096,t=3,p=1$xxx$xxx", refresh the browser

### Expected

Failed to login into the code-server. The hashed-password in the config.yaml should not be the plain credentials

### Actual

successfully login into the code-server

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。