coder / coder/code-server

The value of hashed-password can be used to open CodeServer directly, which has security problem

Abierto
#7,696 1 comentario 0 reacciones 0 asignados Ver en GitHub
bug security triage
Lenguaje dominante
TypeScript
Estrellas
79.3k
Forks
6.8k
Merge medio
2 d 6 h
PR fusionados (30 d)
41

Descripción

### Is there an existing issue for this?

- [x] I have searched the existing issues

### OS/Web Information

- Web Browser: Chrome 143.0.7499.170
- Local OS: windows
- Remote OS: ubuntu 22.04, jupyterlab service
- Remote Architecture: x86
- `code-server --version`: v4.108.0

### Steps to Reproduce

1. prepare "hashed-password" using command `echo -n "xxx" | npx argon2-cli -e`
2. edit ~/.config/code-server/config.yaml,auth: password, hashed-password:"$argon2i$v=19$m=4096,t=3,p=1$xxx$xxx"
3. start code-server using command `code-server --port 7756`
4. using jupyter_server_proxy to visit code-server service, concatenate a URL as https://base_url/proxy/7756/
5. when the code-server login page occurs, skip input the xxx into the password area. F12 edit the application cookie, set key=code-server-session, value="$argon2i$v=19$m=4096,t=3,p=1$xxx$xxx", refresh the browser

### Expected

Failed to login into the code-server. The hashed-password in the config.yaml should not be the plain credentials

### Actual

successfully login into the code-server

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.