coder / coder/backstage-plugins

Coder plugin: clean up error-handling logic

Aperta
#134 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
bug good first issue
Lingua principale
TypeScript
Stelle
67
Fork
9
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

The Coder plugin has some vestigial code from before we started using Axios. Now that we have Axios's `AxiosError`, there's far less of a need for the custom `BackstageHttpError`

In addition, the logic for spying on potentially-expired Coder session tokens can be cleaned up. The current code works, but when a Coder query fails, the plugin will make an entirely brand new request to revalidate the auth state. But if the error has a 401 status, we don't need to do that – we know that the session token is likely invalid, so we can mutate the query cache directly.

Tried to get these fixed really quickly in #132, but it started making the tests fail, so I decided to split this off into a separate issue.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.