codebytere / codebytere/codebytere.github.io

localStorage usage is buggy

Aperta
#16 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
JavaScript
Stelle
546
Fork
105
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

Cool site. Seems the usage of `localStorage` is buggy though. In particular, in this line:

https://github.com/codebytere/codebytere.github.io/blob/3d5854bea758dfe0266b6ffc4b77a0b03a0cb782/js/shell.js#L42

`localStorage.inHistory` will always evaluate to be `true`. That's because everything put into `localStorage` is coerced to a string:

> [The keys and the values are **always strings** (note that, as with objects, integer keys will be automatically converted to strings).](https://developer.mozilla.org/en-US/docs/Web/API/Window/localStorage)

So this line:

https://github.com/codebytere/codebytere.github.io/blob/3d5854bea758dfe0266b6ffc4b77a0b03a0cb782/js/shell.js#L12

is actually setting `inHistory` to the string `"false"`, and `Boolean("false") === true`.

Doesn't look like your usage of `localStorage` persists between page loads (everything resets) so there's no real need to use it.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.