codebytere / codebytere/codebytere.github.io
localStorage usage is buggy
- Dominant language
- JavaScript
- Stars
- 546
- Forks
- 105
- PR merge metrics
- No merged PRs in 30d
Description
Cool site. Seems the usage of `localStorage` is buggy though. In particular, in this line:
https://github.com/codebytere/codebytere.github.io/blob/3d5854bea758dfe0266b6ffc4b77a0b03a0cb782/js/shell.js#L42
`localStorage.inHistory` will always evaluate to be `true`. That's because everything put into `localStorage` is coerced to a string:
> [The keys and the values are **always strings** (note that, as with objects, integer keys will be automatically converted to strings).](https://developer.mozilla.org/en-US/docs/Web/API/Window/localStorage)
So this line:
https://github.com/codebytere/codebytere.github.io/blob/3d5854bea758dfe0266b6ffc4b77a0b03a0cb782/js/shell.js#L12
is actually setting `inHistory` to the string `"false"`, and `Boolean("false") === true`.
Doesn't look like your usage of `localStorage` persists between page loads (everything resets) so there's no real need to use it.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.